Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusted Zoom Speed on Interstellar Map Panel #3967

Merged

Conversation

IllianiCBT
Copy link
Collaborator

Current Implementation

The current zoom calculation, for the Interstellar Map Panel (IMP), is 1.5^(-1 * Mouse Wheel 'Clicks').

Problem

This leaves the IMP feeling a little over-sensitive. Frequently I've found myself going from planetary-level to Milky Way-level in a single mouse wheel roll, as illustrated below:

IMP After 10 Wheel Clicks (From default starting scale) image

Solution

I adjusted the zoom calculation to 1.175^(-1 * Mouse Wheel 'Clicks'). This improves the feel of zooming in & out on the IMP, without excessively slowing either down.

IMP After 10 Wheel Clicks (From default starting scale) image

Copy link

codecov bot commented Apr 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 10.65%. Comparing base (f326428) to head (7058d21).

Files Patch % Lines
MekHQ/src/mekhq/gui/InterstellarMapPanel.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master    #3967   +/-   ##
=========================================
  Coverage     10.65%   10.65%           
  Complexity     5536     5536           
=========================================
  Files           839      839           
  Lines        114370   114370           
  Branches      17201    17201           
=========================================
  Hits          12189    12189           
  Misses       100951   100951           
  Partials       1230     1230           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HammerGS HammerGS merged commit 968b24d into MegaMek:master Apr 6, 2024
5 of 6 checks passed
HammerGS added a commit that referenced this pull request Apr 6, 2024
+ PR #3922: Add missing cockpit costs and weights
+ PR #3944: Added Nag Dialog for Pregnant Combatants
+ Fix #3943: Unmaintained Unit Nag Dialog Suppressed for Units set to
Salvage
+ PR #3933: Fixes for #3729,#3817,#3753: Clamped Unit Rating Mod for
CamOps (redux)
+ PR #3923: Hide Toughness When 0
+ PR #3915: Added Dialog to Confirm New Campaign (redux)
+ PR #3908: Adjusted Default Tech Counts
+ PR #3967: Adjusted Zoom Speed on Interstellar Map Panel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants