Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3949: Custom ScenarioObjectives do not change ScenarioStatus in ResolveScenarioWizardDialog #3950

Conversation

AaronGullickson
Copy link
Member

These fixes will enable checking custom ScenarioObjectives to affect the victory conditions.

Copy link

codecov bot commented Apr 1, 2024

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 10.65%. Comparing base (0a2b4e4) to head (08213ba).
Report is 10 commits behind head on master.

Files Patch % Lines
.../mekhq/gui/dialog/ResolveScenarioWizardDialog.java 0.00% 9 Missing ⚠️
...q/campaign/mission/ScenarioObjectiveProcessor.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3950      +/-   ##
============================================
+ Coverage     10.60%   10.65%   +0.04%     
- Complexity     5487     5528      +41     
============================================
  Files           836      836              
  Lines        114266   114282      +16     
  Branches      17182    17187       +5     
============================================
+ Hits          12121    12176      +55     
+ Misses       100935   100878      -57     
- Partials       1210     1228      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Sleet01 Sleet01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@AaronGullickson AaronGullickson merged commit d988da8 into MegaMek:master Apr 3, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom ScenarioObjectives do not change ScenarioStatus in ResolveScenarioWizardDialog
2 participants