StratCon Air & Arty Modifiers #3947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR addresses a recent RFE to add infantry field guns. Its also adds ASF aces to fill the last hole of the most commonly used units. I dont plan on adding any more at this time unless the ability to sort them by date happens. Regardless, I plan on updating all of the current .mul modifiers to have one for each era. Even without date sorting, they can be added to the repo to their own folder with instructions that users can copy over depending on the era they are playing, or I can just put them in the files forum for people that want to use them.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3947 +/- ##
=========================================
Coverage 10.65% 10.65%
Complexity 5528 5528
=========================================
Files 836 836
Lines 114275 114275
Branches 17185 17185
=========================================
Hits 12176 12176
Misses 100871 100871
Partials 1228 1228 ☔ View full report in Codecov by Sentry. |
HammerGS
reviewed
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a recent RFE to add infantry field guns. Its also adds ASF aces to fill the last hole of the most commonly used units. I dont plan on adding any more at this time unless the ability to sort them by date happens.
Regardless, later I plan on updating all of the current .mul modifiers to have one for each era. Even without date sorting, they can be added to the repo to their own folder with instructions that users can copy over depending on the era they are playing, or I can just put them in the files forum for people that want to use them.
Closes #3894