Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tech/Vessel Column to Tech Skills View #3916

Merged
merged 2 commits into from
Apr 3, 2024

Conversation

IllianiCBT
Copy link
Collaborator

@IllianiCBT IllianiCBT commented Mar 27, 2024

Current Implementation

Currently the Tech Skills view has the following tabs:
image

Problem

This makes it difficult to find those employees with the Tech/Vessel skill.

Solution

Added Tech/Vessel column
image

Also added appropriate Unit Test.

Closes #3890.

@IllianiCBT IllianiCBT changed the title [#3890] Add Tech/Vessel Column to Tech Skills View [#3890] [Enhancement] Add Tech/Vessel Column to Tech Skills View Mar 27, 2024
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 10.60%. Comparing base (0a2b4e4) to head (1d910d1).
Report is 8 commits behind head on master.

Files Patch % Lines
...src/mekhq/gui/enums/PersonnelTableModelColumn.java 40.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master    #3916   +/-   ##
=========================================
  Coverage     10.60%   10.60%           
- Complexity     5487     5489    +2     
=========================================
  Files           836      836           
  Lines        114266   114271    +5     
  Branches      17182    17183    +1     
=========================================
+ Hits          12121    12123    +2     
- Misses       100935   100938    +3     
  Partials       1210     1210           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IllianiCBT IllianiCBT changed the title [#3890] [Enhancement] Add Tech/Vessel Column to Tech Skills View Add Tech/Vessel Column to Tech Skills View Mar 29, 2024
@IllianiCBT IllianiCBT self-assigned this Mar 29, 2024
@IllianiCBT IllianiCBT added the GUI label Mar 29, 2024
@HammerGS HammerGS merged commit 81505d0 into MegaMek:master Apr 3, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFE] Add Vessel/Tech to Tech Skill Filter
3 participants