-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add lances to the force string when sending data to megamek #3901
add lances to the force string when sending data to megamek #3901
Conversation
kuronekochomusuke
commented
Mar 24, 2024
•
edited
Loading
edited
- add lances to the force string when sending data to megamek for bot forces
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3901 +/- ##
============================================
+ Coverage 10.60% 10.65% +0.04%
- Complexity 5487 5528 +41
============================================
Files 836 836
Lines 114267 114293 +26
Branches 17184 17187 +3
============================================
+ Hits 12121 12176 +55
+ Misses 100936 100889 -47
- Partials 1210 1228 +18 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
@kuronekochomusuke The added method You could do that by trying to remove the AtB dependency here, but I would rather you just move |