Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add lances to the force string when sending data to megamek #3901

Merged
merged 6 commits into from
Apr 3, 2024

Conversation

kuronekochomusuke
Copy link
Collaborator

@kuronekochomusuke kuronekochomusuke commented Mar 24, 2024

  • add lances to the force string when sending data to megamek for bot forces

image

@kuronekochomusuke kuronekochomusuke marked this pull request as draft March 24, 2024 20:52
@kuronekochomusuke kuronekochomusuke added the (RFE) Enhancement Requests for Enhancement, new features or implementations label Mar 24, 2024
Copy link

codecov bot commented Mar 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 38 lines in your changes are missing coverage. Please review.

Project coverage is 10.65%. Comparing base (71a87ab) to head (c344a13).
Report is 13 commits behind head on master.

Files Patch % Lines
MekHQ/src/mekhq/GameThread.java 0.00% 36 Missing ⚠️
MekHQ/src/mekhq/AtBGameThread.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3901      +/-   ##
============================================
+ Coverage     10.60%   10.65%   +0.04%     
- Complexity     5487     5528      +41     
============================================
  Files           836      836              
  Lines        114267   114293      +26     
  Branches      17184    17187       +3     
============================================
+ Hits          12121    12176      +55     
+ Misses       100936   100889      -47     
- Partials       1210     1228      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kuronekochomusuke kuronekochomusuke marked this pull request as ready for review March 27, 2024 23:04
Copy link
Collaborator

@Sleet01 Sleet01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@kuronekochomusuke kuronekochomusuke merged commit e3c042d into MegaMek:master Apr 3, 2024
5 of 6 checks passed
@AaronGullickson
Copy link
Member

@kuronekochomusuke The added method GameThread.setupBotForces depends on all missions being AtBContracts by recasting them as such. However, this is the GameThread not the AtBGameThread. This means it will lead to errors for anybody not running AtB. That needs to be corrected. I can't merge master into Story Arcs at the moment because this issue will render it non-functional.

You could do that by trying to remove the AtB dependency here, but I would rather you just move GameThread.setupBotForces to AtBGameThread and revert the GameThread back to its prior state. I think there may be better ways to handle this issue for the non-AtB case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
(RFE) Enhancement Requests for Enhancement, new features or implementations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants