Disconnect quietly from GameThread for MekHQ #3900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronGullickson
added
(RFE) Enhancement
AaronGullickson
requested review from
Windchild292,
neoancient,
SJuliez and
NickAragua
and removed request for
Windchild292
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3900 +/- ##
============================================
- Coverage 10.64% 10.64% -0.01%
Complexity 5487 5487
============================================
Files 834 834
Lines 113856 113858 +2
Branches 17193 17193
============================================
Hits 12119 12119
- Misses 100528 100530 +2
Partials 1209 1209 ☔ View full report in Codecov by Sentry. |
NickAragua
approved these changes
Mar 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the new feature in Megamek from PR MegaMek/megamek#5277 to disconnect quietly from the GameThread and AtBGameThread in MekHQ. So when users complete a scenario, they will no longer get the "Disconnected!" popup window which just gets in the way.