#3763 reversing quality names in unit set quality GM menu #3824
Conversation
|
Just found that the quality names also need to reverse in the Campaign Options > Finances > Price Multipliers > Used Parts Value Multipliers. I'll look into this in a day or two. |
All done now. |
| Object[] possibilities = { Part.getQualityName(Part.QUALITY_A, reverse), | ||
| Part.getQualityName(Part.QUALITY_B, reverse), Part.getQualityName(Part.QUALITY_C, reverse), | ||
| Part.getQualityName(Part.QUALITY_D, reverse), Part.getQualityName(Part.QUALITY_E, reverse), | ||
| Part.getQualityName(Part.QUALITY_F, reverse) }; |
There was a problem hiding this comment.
Check the review guide as this is a little hard to read. Might need to put each quality on its own line to make reading it easier.
There was a problem hiding this comment.
Moved each to its own line. Also did this in PartsTableMouseAdapter where I copied this chunk from.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3824 +/- ##
============================================
- Coverage 10.63% 10.62% -0.01%
+ Complexity 5474 5472 -2
============================================
Files 834 834
Lines 113836 113841 +5
Branches 17198 17198
============================================
- Hits 12106 12101 -5
- Misses 100524 100533 +9
- Partials 1206 1207 +1 ☔ View full report in Codecov by Sentry. |
This fixes #3763. When setting the quality of a unit in the Hangar the quality names are properly reversed.
Code duplicated from PartsTableMouseAdapter#actionPerformed