map preset data and default graphics fix #3715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #3715 +/- ##
============================================
- Coverage 10.64% 10.64% -0.01%
Complexity 5473 5473
============================================
Files 834 834
Lines 113678 113679 +1
Branches 17175 17174 -1
============================================
Hits 12099 12099
- Misses 100373 100374 +1
Partials 1206 1206
☔ View full report in Codecov by Sentry. |
SJuliez
approved these changes
Jul 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of presets had illegal structure CF values (max is 150), so those have been dropped down.
Also, if there's no image configured for a given biome type or for legacy contracts, continue drawing hex outlines.
Also fixes #3402 by only displaying hostile units on the killboard during scenario resolution. Probably fixes #3715 as that's likely the same issue.