Update refit classes based on CamOps #3662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Engines, gyros, armor, cockpits, and myomer have different refit classes now. Actuators do not get special treatment. Some edge cases may still need to be added, such as Full-Head Ejection.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3662 +/- ##
=========================================
Coverage 10.65% 10.66%
Complexity 5472 5472
=========================================
Files 830 830
Lines 113508 113499 -9
Branches 17159 17156 -3
=========================================
Hits 12099 12099
+ Misses 100201 100193 -8
+ Partials 1208 1207 -1
☔ View full report in Codecov by Sentry. |
Windchild292
approved these changes
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I haven't addressed every problem in #3515, I've updated many of the refit classes to bring MekHQ closer to current tabletop rules.
I've also tested it: assuming refit classes in the window for choosing a refit don't reflect the benefit of a refit kit, it is working as expected.