Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Company Generator: Prevent Preset From Loading in Older Versions #3582

Conversation

Windchild292
Copy link
Contributor

This fixes a bug whereby you can open a preset in an older version, which will almost certainly cause issues.

@Windchild292 Windchild292 self-assigned this Jan 26, 2023
@codecov
Copy link

codecov bot commented Jan 26, 2023

Codecov Report

Base: 10.96% // Head: 10.96% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (ade1bf6) compared to base (1aaeaaa).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3582      +/-   ##
============================================
- Coverage     10.96%   10.96%   -0.01%     
  Complexity     5508     5508              
============================================
  Files           829      829              
  Lines        113285   113289       +4     
  Branches      17115    17115              
============================================
  Hits          12426    12426              
- Misses        99636    99640       +4     
  Partials       1223     1223              
Impacted Files Coverage Δ
...se/companyGeneration/CompanyGenerationOptions.java 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Windchild292 Windchild292 merged commit 3aa6dee into MegaMek:master Feb 7, 2023
@Windchild292 Windchild292 deleted the dev_Windchild_ModernCampaignGenerationOptionsPreset branch February 7, 2023 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants