Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3146: Fixing NPEs in Campaign::getForceFor to handle NPE raised from unit assignment. #3148

Merged
merged 1 commit into from
Mar 9, 2022

Conversation

Windchild292
Copy link
Contributor

This fixed #3146 and fixes the annotation setup that led to that issue.

@Windchild292 Windchild292 self-assigned this Mar 1, 2022
@codecov
Copy link

codecov bot commented Mar 1, 2022

Codecov Report

Merging #3148 (88ce57b) into master (d626b44) will decrease coverage by 0.04%.
The diff coverage is 36.11%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3148      +/-   ##
============================================
- Coverage      9.93%    9.89%   -0.05%     
+ Complexity     4062     4054       -8     
============================================
  Files           816      818       +2     
  Lines        112168   112075      -93     
  Branches      17200    17197       -3     
============================================
- Hits          11149    11086      -63     
+ Misses        99635    99600      -35     
- Partials       1384     1389       +5     
Impacted Files Coverage Δ
MekHQ/src/mekhq/MekHqXmlUtil.java 11.96% <0.00%> (ø)
MekHQ/src/mekhq/Utilities.java 2.79% <0.00%> (-0.44%) ⬇️
MekHQ/src/mekhq/campaign/Campaign.java 12.03% <0.00%> (-0.03%) ⬇️
MekHQ/src/mekhq/campaign/finances/Loan.java 0.00% <0.00%> (ø)
MekHQ/src/mekhq/campaign/force/UnitStub.java 0.00% <0.00%> (ø)
MekHQ/src/mekhq/campaign/log/PersonalLogger.java 0.00% <0.00%> (ø)
MekHQ/src/mekhq/campaign/log/ServiceLogger.java 19.14% <0.00%> (-0.42%) ⬇️
...mpaign/market/unitMarket/AtBMonthlyUnitMarket.java 0.00% <0.00%> (ø)
...hq/campaign/mission/AtBDynamicScenarioFactory.java 1.59% <0.00%> (ø)
MekHQ/src/mekhq/campaign/mission/AtBScenario.java 0.00% <0.00%> (ø)
... and 64 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5cf3c43...88ce57b. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[0.49.7 : Bug] NPE When Assigning Crews
2 participants