Skill Generation: Phenotype Bonus Applies to Proper Skills

[Windchild292]

Taharqa found this issue, and raised it on Discord.

I also moved the non-clanner return to the top, as it should be an immediate return case.

[codecov]

Codecov Report

Merging #3007 (091bcb2) into master (167557c) will increase coverage by 0.50%.
The diff coverage is 0.00%.

❗ Current head 091bcb2 differs from pull request most recent head 28e68e6. Consider uploading reports for the commit 28e68e6 to get more accurate results

@@             Coverage Diff              @@
##             master    #3007      +/-   ##
============================================
+ Coverage     10.20%   10.70%   +0.50%     
+ Complexity     4053     3992      -61     
============================================
  Files           773      749      -24     
  Lines        109048   101757    -7291     
  Branches      16953    16611     -342     
============================================
- Hits          11127    10896     -231     
+ Misses        96529    89490    -7039     
+ Partials       1392     1371      -21     

Impacted Files	Coverage Δ
...gn/personnel/generator/AbstractSkillGenerator.java	0.00% <0.00%> (ø)
...ign/personnel/generator/DefaultSkillGenerator.java	0.00% <0.00%> (ø)
MekHQ/src/mekhq/campaign/rating/IUnitRating.java	0.00% <0.00%> (-100.00%)	⬇️
...q/campaign/personnel/enums/FormerSpouseReason.java	43.75% <0.00%> (-3.31%)	⬇️
MekHQ/src/mekhq/campaign/log/AwardLogger.java	33.33% <0.00%> (-3.04%)	⬇️
...HQ/src/mekhq/campaign/rating/UnitRatingMethod.java	47.05% <0.00%> (-2.95%)	⬇️
...paign/personnel/enums/RandomProcreationMethod.java	53.33% <0.00%> (-2.92%)	⬇️
.../mekhq/campaign/market/enums/UnitMarketMethod.java	57.14% <0.00%> (-2.86%)	⬇️
...sonnel/enums/FamilialRelationshipDisplayLevel.java	39.13% <0.00%> (-2.54%)	⬇️
...mpaign/enums/PlanetaryAcquisitionFactionLimit.java	33.33% <0.00%> (-2.39%)	⬇️
... and 387 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8651b9...28e68e6. Read the comment docs.

[SJuliez]

I do have a request for this.