Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AbstractIcon: Null Protection for ImageIcons and Separating Dialogs out from the Choosers beneath #2285

Merged

Conversation

Windchild292
Copy link
Contributor

This is the MHQ-side of MegaMek/megamek#2509 , and MUST be merged at the same time.

@codecov
Copy link

codecov bot commented Dec 13, 2020

Codecov Report

Merging #2285 (57947db) into master (03ffd7d) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #2285   +/-   ##
========================================
  Coverage      8.28%   8.28%           
  Complexity     2587    2587           
========================================
  Files           673     673           
  Lines         95085   95085           
  Branches      15983   15983           
========================================
  Hits           7876    7876           
  Misses        86142   86142           
  Partials       1067    1067           
Impacted Files Coverage Δ Complexity Δ
.../mekhq/gui/adapter/PersonnelTableMouseAdapter.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
MekHQ/src/mekhq/gui/dialog/NewRecruitDialog.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03ffd7d...57947db. Read the comment docs.

@Windchild292 Windchild292 merged commit cef9aba into MegaMek:master Dec 14, 2020
@Windchild292 Windchild292 deleted the dev_Windchild_AbstractIconNull branch December 14, 2020 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant