-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve performance of purchasing parts and fix refit bug #1419
Merged
sixlettervariables
merged 14 commits into
MegaMek:master
from
sixlettervariables:purchase-part-performance
Jan 24, 2020
Merged
Improve performance of purchasing parts and fix refit bug #1419
sixlettervariables
merged 14 commits into
MegaMek:master
from
sixlettervariables:purchase-part-performance
Jan 24, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickAragua
reviewed
Jan 23, 2020
- Add new overload for IPartWork::getDetails to optionally include repair details.
NickAragua
approved these changes
Jan 24, 2020
sixlettervariables
added a commit
to sixlettervariables/mekhq
that referenced
this pull request
Jan 25, 2020
- Ensure all overrides of getDetails include an override of getDetails(boolean)
sixlettervariables
added a commit
that referenced
this pull request
Jan 26, 2020
Fix bug introduced in getDetails via #1419
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating an issue where ammo could not be bought, I noticed a number of huge performance slowdowns in the Purchase Parts screen. I also found a bug w.r.t. refit ID's.
The time it takes to purchase 1000 units of AC/20 ammo by clicking 'Buy' is cut by ~70% on my desktop.
These commits are best viewed one by one with whitespace ignored (although I tried to minimize whitespace changes).