Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent messaging in Daily Activity Log: ComStar bill vs. C-Bill #3740

Closed
SuperStucco opened this issue Aug 1, 2023 · 2 comments · Fixed by #3825
Closed

Consistent messaging in Daily Activity Log: ComStar bill vs. C-Bill #3740

SuperStucco opened this issue Aug 1, 2023 · 2 comments · Fixed by #3825

Comments

@SuperStucco
Copy link

In 49.12, there is a difference in messaging between prisoner ransoms:

25,000 ComStar bill has been credited to your account for prisoner ransoms following Assassinate.

... and battle loss compensation:
7,290 C-Bill in battle loss compensation (parts) for Shadow Hawk SHD-2H has been credited to your account.

There may be other cases where this is different. I recommend settling on "C-Bills" (1 C-Bill is going to be extremely uncommon, so plural will work in almost every case) as the single term, and a general review of Activity Log messages so that it is consistent across all uses. Possibly switching to a constant or similar value in string building.

@pheonixstorm
Copy link
Collaborator

I think this was added/changed in some areas when the finance backend was reworked. Maybe around 2017/2018. Its possible it could have gotten worse since then as well.

@nutritiousemployee
Copy link
Contributor

in ResolveScenarioTracker, one message is using toAmountAndNameString - name being "ComStar bill", the other toAmountAndSymbolString - with the currency symbol being "C-Bill"
I can see toAmountAndNameString being used only in 3 places (unit ransoms, prisoner ransoms and exporting finances to CSV) while the other method is used everywhere else. Might be worth to use the symbol everywhere?

jackreichelt added a commit to jackreichelt/mekhq that referenced this issue Jan 31, 2024
neoancient added a commit that referenced this issue Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants