Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load Last Save produces error #3424

Closed
MaridaConnoisseur opened this issue Aug 5, 2022 · 2 comments
Closed

Load Last Save produces error #3424

MaridaConnoisseur opened this issue Aug 5, 2022 · 2 comments
Assignees
@Windchild292
Labels
Bug

Comments

@MaridaConnoisseur
Copy link

Version: 0.49.8
OS: Windows 11 21H2
Java Vendor: Eclipse Adoptium
Java Version: 11.0.16

When clicking 'Load Last Save', an error "Cannot parse the version from . This may lead to severe issues that cannot be otherwise explained." shows up, and instead loads a new, nameless mercenary campaign at Janurary 1, 3067 starting at Outreach.

Reproduction:
Click 'Load Last Save'

501st Autonomous Regiment.cpnx.gz
megameklab.log
legacy.log
@Windchild292
Copy link
Contributor

That's not the last file that's being loaded, and loads fine. However, this does bring up some missing error case handling, which I'm looking at now.

@Windchild292 Windchild292 self-assigned this Aug 6, 2022
@Windchild292 Windchild292 mentioned this issue Aug 6, 2022
Merged
HammerGS added a commit that referenced this issue Sep 3, 2022
@HammerGS
+ PR #3424:
8045d59 
Properly fail to load a Campaign when the version can't be parsed
@Windchild292
Copy link
Contributor

This has been resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Windchild292 Windchild292

Labels
Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Windchild292 @MaridaConnoisseur