Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recursion in BattleArmorSuit::getTonnage #1115

Closed
sixlettervariables opened this issue Feb 25, 2019 · 1 comment
Closed

Recursion in BattleArmorSuit::getTonnage #1115

sixlettervariables opened this issue Feb 25, 2019 · 1 comment
Labels
Bug Good First Issue A good issue to tackle for new MekHQ developers

Comments

@sixlettervariables
Copy link
Contributor

Not sure if its related but the the log file has some errors around equipment. Which I suspect is hand modifications to custom unit files.

Also the last error listed in the log is thousands of lines of

Exception in thread "AWT-EventQueue-0" java.lang.StackOverflowError
	at java.util.TreeMap.getEntry(Unknown Source)
	at java.util.TreeMap.get(Unknown Source)
	at mekhq.campaign.Campaign.getPart(Campaign.java:1665)
	at mekhq.campaign.parts.BattleArmorSuit.getTonnage(BattleArmorSuit.java:225)
	at mekhq.campaign.parts.BattleArmorSuit.getTonnage(BattleArmorSuit.java:227)

Originally posted by @HammerGS in MegaMek/megamek#1271 (comment)
@sixlettervariables
Copy link
Contributor Author

Apparently I missed this in #1011

@sixlettervariables sixlettervariables added Bug Good First Issue A good issue to tackle for new MekHQ developers labels Feb 25, 2019
sixlettervariables added a commit to sixlettervariables/mekhq that referenced this issue Feb 26, 2019
@sixlettervariables
Do not recurse in BattleArmorSuit::getTonnage MegaMek#1115
56353d5
@sixlettervariables sixlettervariables mentioned this issue Feb 26, 2019
Merged
sixlettervariables added a commit that referenced this issue Feb 26, 2019
@sixlettervariables
Merge pull request #1120 from sixlettervariables/bug-1115-ba-gettonna…
34631f9 
…ge-recursion

Fix stack overflow in BattleArmorSuit::getTonnage #1115
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Good First Issue A good issue to tackle for new MekHQ developers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sixlettervariables