Set techlevel of armor in specific location, not entire mek, when setting patchwork armor #1634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ting patchwork armor
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1634 +/- ##
========================================
Coverage 2.17% 2.17%
Complexity 209 209
========================================
Files 266 266
Lines 30760 30758 -2
Branches 5260 5259 -1
========================================
Hits 669 669
+ Misses 29934 29932 -2
Partials 157 157 ☔ View full report in Codecov by Sentry. |
HammerGS
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires MegaMek/megamek#6078 to produce correct mixed-tech patchwork armor mtfs.
Currently, setting the armor in one location sets the armor tech level of every location, creating situations where we try to load a unit with Heavy Ferro-Fibrous (Clan) and other nonsense armors.