Choosing Elevation at Deployment #5996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion chooser and helper
# Conflicts: # megamek/src/megamek/common/Entity.java
# Conflicts: # megamek/src/megamek/client/ui/swing/DeploymentDisplay.java # megamek/testresources/data/scenarios/test_setups/AeroScenSpace.mms # megamek/testresources/data/scenarios/test_setups/DeploymentTest.mms # megamek/testresources/data/scenarios/test_setups/testiceonwater.board
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5996 +/- ##
============================================
- Coverage 29.07% 29.05% -0.02%
Complexity 13958 13958
============================================
Files 2576 2580 +4
Lines 267398 267509 +111
Branches 47803 47820 +17
============================================
+ Hits 77735 77736 +1
- Misses 185761 185869 +108
- Partials 3902 3904 +2 ☔ View full report in Codecov by Sentry. |
neoancient
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #5956, this adds a more comprehensive elevation/altitude choice during deployment. Lobby elevation settings are (for now) ignored, except that Princess still has to follow them, so they still make sense for bots.
VTOLs can deploy at high elevations using "Choose Elevation" and entering the value manually.
The choice dialog is shown only if there are multiple options and if those differ enough from previous hex options or the previous choice can't be used in a new hex (in other words: the code tries not to show it for each hex). The dialog can always be brought up by clicking the same hex again (provided there is more than 1 choice of elevation).
Note that with selectable elevations/altitudes the yellow deployment marker hexes don't always show correctly where a unit can deploy. This requires some bigger changes to fix that I did not want to start on now.