Replace quirk 'compact_mech' with 'ubiquitous' for all Locusts #5921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Until this Errata is resolved - https://bg.battletech.com/forums/index.php?topic=5884.msg2027590#msg2027590 We shouldn't merge this. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5921 +/- ##
=========================================
Coverage 28.90% 28.91%
- Complexity 13929 13933 +4
=========================================
Files 2539 2539
Lines 268363 268363
Branches 47933 47933
=========================================
+ Hits 77579 77586 +7
+ Misses 186819 186812 -7
Partials 3965 3965 ☔ View full report in Codecov by Sentry. |
Thanks, I didn't know this existed 👍 |
SJuliez
added
the
CGL clarification Required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, all Locusts (not Locust IIC) have the
Compact 'Mechquirk in MegaMek. That is also the case in the physical BattleMech Manual that I own (6th printing). However, in the latest edition (7th printing, PDF from 12/13/23) they changed the Locust's quirks and replacedCompact 'MechwithUbiquitous. This PR changes the Locust MTF files accordingly.