#5817: Re-apply round increase fix from #5545 #5891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5891 +/- ##
=========================================
Coverage 28.90% 28.90%
- Complexity 13926 13930 +4
=========================================
Files 2539 2539
Lines 268364 268362 -2
Branches 47935 47933 -2
=========================================
+ Hits 77576 77580 +4
+ Misses 186820 186818 -2
+ Partials 3968 3964 -4 ☔ View full report in Codecov by Sentry. |
rjhancock
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The round increase fix of #5545 got lost, probably because it applied to GameManager, but the actual code was move to TWPhasePreparationManager around the same time. This re-applies it.
#Fixes #5817
I hope :)