Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow bot vs bot in ScenarioV2 and test setup #5835

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

SJuliez
Copy link
Member

@SJuliez SJuliez commented Aug 1, 2024

A tiny change that allows leaving the human player in a scenario with no units and thus have two bots fight it out.

Best hide whitespace when reviewing. The diff looks big, but it only surrounds the unit reader with a check if there is a unit node, new line 218

Copy link

codecov bot commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.01%. Comparing base (d349884) to head (7920791).
Report is 2 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5835      +/-   ##
============================================
- Coverage     29.01%   29.01%   -0.01%     
  Complexity    13923    13923              
============================================
  Files          2511     2511              
  Lines        267117   267118       +1     
  Branches      47784    47785       +1     
============================================
  Hits          77504    77504              
- Misses       185661   185662       +1     
  Partials       3952     3952              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Sleet01 Sleet01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HammerGS HammerGS merged commit 7b33c02 into MegaMek:master Aug 1, 2024
5 checks passed
HammerGS added a commit that referenced this pull request Aug 1, 2024
+ Fix #5769:  Possibly fix ID overlap when reinforcing from MUL
+ PR #5835: Allow bot vs bot in ScenarioV2 and test setup
+ Fix #5833: GameReports: remove error message and deal with missing rounds
+ Fix #5833: Precognition: receive updated ground objects
@SJuliez SJuliez deleted the bot-bot-scenario branch October 15, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants