Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Munition autoconfig tweaks #5738

Conversation

Sleet01
Copy link
Collaborator

@Sleet01 Sleet01 commented Jul 15, 2024

Thanks to some early QA work, a number of errors in the "final" munition autoconfig code have been identified.
This patch will:

  1. Fix Artemis munitions being selected for non-Artemis launchers;
  2. Update legality check on ammo types to always use year restrictions with the option to use variable era tech levels;
  3. Add tracking of enemy TSM units for consideration when weighting heat-producing munitions;
  4. Split "missing munitionLoadoutSettings.xml" error into user warning and debug message with full exception;
  5. Adjust "energy boat" unit accounting to only care about those that track heat;
  6. Updated some isAvailable() methods to allow Clans access to IS equipment at the same availability from the Clan Invasion era onward, per IO pg 33.
  7. Fix errors in getPrototypeDate and getProductionDate that would return no date for munitions missing the Common and/or Production entry (e.g. Air-Defence Arrow Missiles), causing some tech to be unavailable to certain combinations of faction and clan/mixed tech bases.
  8. Updated unit tests

Testing:

  • Ran all 3 projects' unit tests
  • Tested with a number of factions, Clan/IS/Mixed tech levels, and eras, alternating Variable Tech off and on.

Copy link

codecov bot commented Jul 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.09%. Comparing base (638894f) to head (9523421).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #5738   +/-   ##
=========================================
  Coverage     29.09%   29.09%           
- Complexity    13879    13900   +21     
=========================================
  Files          2506     2506           
  Lines        265961   265979   +18     
  Branches      47559    47565    +6     
=========================================
+ Hits          77377    77395   +18     
+ Misses       184684   184669   -15     
- Partials       3900     3915   +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@IllianiCBT IllianiCBT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took a read through and everything looks good to me :)

@Sleet01 Sleet01 merged commit ada52c4 into MegaMek:master Jul 15, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants