Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Sentry to project #5689

Merged
merged 7 commits into from
Jul 7, 2024
Merged

Conversation

rjhancock
Copy link
Collaborator

Updated MegaMek.java with sentry and initial error tracking Updated CI to package zip/tar only
Updated Build scripts for single distribution package

Updated MegaMek.java with sentry and initial error tracking
Updated CI to package zip/tar only
Updated Build scripts for single distribution package
Copy link

codecov bot commented Jul 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.33%. Comparing base (b21b5d6) to head (9845c61).
Report is 18 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5689      +/-   ##
============================================
- Coverage     29.34%   29.33%   -0.01%     
+ Complexity    13872    13871       -1     
============================================
  Files          2466     2467       +1     
  Lines        263319   263368      +49     
  Branches      47172    47179       +7     
============================================
+ Hits          77266    77270       +4     
- Misses       182163   182213      +50     
+ Partials       3890     3885       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Set release version within startup
Updated Copyrights to 2024
Added Logging Constants or MM
Removed warnings from SonarLint
Copy link
Member

@SJuliez SJuliez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fwiw

@SJuliez
Copy link
Member

SJuliez commented Jul 6, 2024

Can I ask you to maybe give your auto formatter a shutdown? I feel some of the things that are happening aren't really helpful. Screens these days have a width above 40 characters :) And writing every parameter on its own line may sometimes be good but not as a baseline from the auto formatter. Thanks.

@rjhancock
Copy link
Collaborator Author

The each parameter on it's own line for longer functions is actually me, not the auto-formatter. Got into that habit from my work in Swift. If the entire call fits within 120 characters, I leave it, if it went over, I split each on its own line.

It became easier for me to read as the IDE also put the variable names from the function inline.

@HammerGS HammerGS merged commit b9928aa into MegaMek:master Jul 7, 2024
5 checks passed
@rjhancock rjhancock deleted the rjh-sentry-unhandled branch July 7, 2024 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants