-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Sentry to project #5689
Added Sentry to project #5689
Conversation
Updated MegaMek.java with sentry and initial error tracking Updated CI to package zip/tar only Updated Build scripts for single distribution package
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5689 +/- ##
============================================
- Coverage 29.34% 29.33% -0.01%
+ Complexity 13872 13871 -1
============================================
Files 2466 2467 +1
Lines 263319 263368 +49
Branches 47172 47179 +7
============================================
+ Hits 77266 77270 +4
- Misses 182163 182213 +50
+ Partials 3890 3885 -5 ☔ View full report in Codecov by Sentry. |
Set release version within startup
Updated Copyrights to 2024 Added Logging Constants or MM Removed warnings from SonarLint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fwiw
Can I ask you to maybe give your auto formatter a shutdown? I feel some of the things that are happening aren't really helpful. Screens these days have a width above 40 characters :) And writing every parameter on its own line may sometimes be good but not as a baseline from the auto formatter. Thanks. |
The each parameter on it's own line for longer functions is actually me, not the auto-formatter. Got into that habit from my work in Swift. If the entire call fits within 120 characters, I leave it, if it went over, I split each on its own line. It became easier for me to read as the IDE also put the variable names from the function inline. |
Updated MegaMek.java with sentry and initial error tracking Updated CI to package zip/tar only
Updated Build scripts for single distribution package