Changed all instances of the role "infantry_support" to "inf_support" #5644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. This doesn't actually change the function of anything, just makes troubleshooting easier. See PR MegaMek#5289 and Issue MegaMek#5267. Ran 317 tests, 312 passed, 5 ignored. Also manually tested Force Generator to make sure the effected units and formations still appear.
|
Just a question on this if the issue is between code and notes, why don't we fix the notes as Infantry_Support in the code seems clearer? |
|
Either is fine with me. |
|
Do we have a precedent for uses of |
|
Can we change the supporting documentation rather than code. Going forward we can ensure X_support the X can be a full name to be very clear what we are looking at,. |
HammerGS
added a commit
that referenced
this pull request
Jun 30, 2024
|
Closing as addressed with 0274235 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed all instances of the role "infantry_support" to "inf_support". This doesn't actually change the function of anything, just makes troubleshooting easier. See PR #5289 and Issue #5267.
Ran 317 tests, 312 passed, 5 ignored. Also manually tested Force Generator to make sure the effected units and formations still appear.