-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RATGen/force generator role handling updates #5527
RATGen/force generator role handling updates #5527
Conversation
…y - less-than/greater-than comparisons on enum int equivalents are not always clear.
…mostly infantry-related. General readability improvements, such as re-sequencing switch bock to group related roles, replacing array index calls with named variables, and descriptive commenting. Updated tests to better reflect current range of units and capabilities.
… be easily excluded from use in combat roles.
…ts without the direct FIRE_SUPPORT or SR_FIRE_SUPPORT role
…pment checks and role
…, BA_CARRIER roles
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not able to see any issues here. Glad to see some of the missing roles added and our coverage expanded.
Never mind, I got so excited I failed to notice the PR is still in Draft. >_> |
Just making sure there isn't any last minute changes prompted by a round of data changes, now ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (for real this time)
The role handling for converting the force generator XMLs to RAT tables/generating random forces has a few holes that need patching, mostly around infantry roles and non-combat units. There were also a few errors, such as limiting MINELAYER/MINESWEEPER to Mechs (rather than ground vehicles) and infantry.
closes #5286
Role/unit type validation:
Availability value modifications by role:
Non-combat/support unit identification:
Role parser:
Help file is updated to list the full set of roles, along with valid unit types and typical uses.