Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cargo loading on SV #5520

Merged
merged 2 commits into from
May 29, 2024
Merged

Cargo loading on SV #5520

merged 2 commits into from
May 29, 2024

Conversation

SJuliez
Copy link
Member

@SJuliez SJuliez commented May 28, 2024

Fixes #5515

This removes code that tried to add cargo bays for F_CARGO equipment. I assume this was added to facilitate the internal bomb bay quirk. Cargo bays count towards weight and cannot be added in this way. I played around with this quite a bit and found that it was somewhat ineffective on units that can possibly have IBB (DS, SC, FWS, AF and CF). DS and SC do not use the that part of the code. F_CARGO is only on Cargo Containers (10t) and variable size cargo bays. For cargo bays, adding more cargo bays seems redundant (and didnt even work for a reason I couldn't see). For cargo containers, they seem not accessible to IBB with or without this code. I suppose we have to find another way to allow IBB in containers.

This makes a handful of SV canon units valid again, see #5509

Also (helpfully) adds transports to the output of DebugEntity.

@SJuliez SJuliez requested a review from Sleet01 May 28, 2024 16:14
Copy link
Collaborator

@Sleet01 Sleet01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'd guess that the F_CARGO block in BLKFile.java was a remnant I should have deleted after the ASF BLK file loader got it added.

@SJuliez SJuliez merged commit aa4c78d into MegaMek:master May 29, 2024
4 checks passed
@SJuliez SJuliez deleted the sv-load-cargo-2 branch June 2, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[0.49.19.1] Bug: Megamek incorrectly loading support vehicles with Cargo Containers as invalid
2 participants