Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradle and Github changes for JRE 17 Min #5512

Merged
merged 9 commits into from
Jun 29, 2024
Merged

Conversation

rjhancock
Copy link
Collaborator

These are the minimal changes needed for Java 17 as the minimal version.

Copy link
Collaborator

@Sleet01 Sleet01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I assume this will wait until 0.49.20 is released?

Copy link
Member

@SJuliez SJuliez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to note that by the time we merge this, the dependencies updates may become downgrades.

@rjhancock
Copy link
Collaborator Author

By the time we merge this, I'll do a cursory check to ensure they're updated. :)

Here's hoping it is sooner rather than later.

Gradle Build Updates.
@rjhancock rjhancock marked this pull request as ready for review June 28, 2024 21:27
Copy link

codecov bot commented Jun 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.31%. Comparing base (1a62656) to head (2f8688a).
Report is 45 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##             master    #5512    +/-   ##
==========================================
  Coverage     29.30%   29.31%            
- Complexity    13783    13802    +19     
==========================================
  Files          2461     2463     +2     
  Lines        262663   262826   +163     
  Branches      47007    47033    +26     
==========================================
+ Hits          76967    77038    +71     
- Misses       181831   181915    +84     
- Partials       3865     3873     +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rjhancock
Copy link
Collaborator Author

Actions are passing. Ready for merge.

@HammerGS
Copy link
Member

Given the approvals and moving up the 0.50.0 release merging these.

@HammerGS HammerGS merged commit 296f885 into MegaMek:master Jun 29, 2024
5 checks passed
@rjhancock rjhancock deleted the java-17 branch June 29, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants