Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bay ammo correction #5465

Merged
merged 2 commits into from
May 16, 2024
Merged

Bay ammo correction #5465

merged 2 commits into from
May 16, 2024

Conversation

SJuliez
Copy link
Member

@SJuliez SJuliez commented May 12, 2024

  • Fixes an obvious error that made probably all large aeros invalid by not finding their bay ammo.
  • Fixes (I guess, I don't see how this could have worked before) a test class. I moved around stuff in there but the main change is calling EquipmentType.initializeTypes() before the tests.

Copy link
Collaborator

@Sleet01 Sleet01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
It probably worked previously because the Dropship BLK strings would load even without the equipment being initialized, because cargo bays weren't "equipment" per se.
I imagine that things are stricter now, after all the updates in .20.

@HammerGS HammerGS closed this in 8d913ad May 16, 2024
@Sleet01 Sleet01 reopened this May 16, 2024
@Sleet01 Sleet01 merged commit b1900fd into MegaMek:master May 16, 2024
7 checks passed
@SJuliez SJuliez deleted the bay-ammo-correction branch May 17, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants