Candidate fix for #5417 NPE Freeze bot moves invalid or nonsense. #5430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
megamek/src/megamek/common/Game.java
Outdated
| @@ -674,11 +674,11 @@ public GamePhase getPhase() { | |||
| public void receivePhase(GamePhase phase) { | |||
| final GamePhase oldPhase = this.phase; | |||
There was a problem hiding this comment.
should this be remove since oldPhase is no longer used
There was a problem hiding this comment.
Yes that should be removed. - I saw that after I committed it.
kuronekochomusuke
approved these changes
Apr 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5417
Moved
processGameEvent()back intosetPhase()where it was.setPhase()gets called from places currently thatreceivePhase()doesn't get called from. It looks like this was pulled out as a refactor but has un-intended side effects for the bots processing.Before making this tweak, I was able to easily reproduce the NPE by running a bot vs bot as described in #5417. After this change, the bot games end naturally after 15 to 25 rounds. Before this tweak, the same bot games would either end in a NPE or infinite mindless bot moves that would go into over 100 rounds.