-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Boardview: Extract Shadowmap #5318
Conversation
# Conflicts: # megamek/src/megamek/client/ui/swing/boardview/BoardView.java
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5318 +/- ##
============================================
+ Coverage 29.09% 29.11% +0.02%
- Complexity 13459 13473 +14
============================================
Files 2390 2390
Lines 260774 260685 -89
Branches 46766 46743 -23
============================================
+ Hits 75868 75899 +31
+ Misses 181232 181121 -111
+ Partials 3674 3665 -9 ☔ View full report in Codecov by Sentry. |
This moves the shadowmap creation out of BoardView. The goal is to make BoardView smaller so it becomes more palatable and I can extract the parts from it that deal with Entity, i.e. Total Warfare stuff and get down to a base boardview that I can use for other game types.