Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boardview: Extract Shadowmap #5318

Merged
merged 8 commits into from
Apr 20, 2024

Conversation

SJuliez
Copy link
Member

@SJuliez SJuliez commented Apr 6, 2024

This moves the shadowmap creation out of BoardView. The goal is to make BoardView smaller so it becomes more palatable and I can extract the parts from it that deal with Entity, i.e. Total Warfare stuff and get down to a base boardview that I can use for other game types.

@SJuliez SJuliez added the For New Dev Cycle This PR should be merged at the beginning of a dev cycle label Apr 6, 2024
# Conflicts:
#	megamek/src/megamek/client/ui/swing/boardview/BoardView.java
Copy link

codecov bot commented Apr 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 212 lines in your changes are missing coverage. Please review.

Project coverage is 29.11%. Comparing base (0742934) to head (00711c0).
Report is 73 commits behind head on master.

❗ Current head 00711c0 differs from pull request most recent head 63f33ae. Consider uploading reports for the commit 63f33ae to get more accurate results

Files Patch % Lines
...client/ui/swing/boardview/TerrainShadowHelper.java 0.00% 196 Missing ⚠️
megamek/src/megamek/common/util/ImageUtil.java 0.00% 11 Missing ⚠️
...c/megamek/client/ui/swing/boardview/BoardView.java 0.00% 4 Missing ⚠️
...c/megamek/client/ui/swing/tileset/EntityImage.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5318      +/-   ##
============================================
+ Coverage     29.09%   29.11%   +0.02%     
- Complexity    13459    13473      +14     
============================================
  Files          2390     2390              
  Lines        260774   260685      -89     
  Branches      46766    46743      -23     
============================================
+ Hits          75868    75899      +31     
+ Misses       181232   181121     -111     
+ Partials       3674     3665       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SJuliez SJuliez merged commit 2e77bb3 into MegaMek:master Apr 20, 2024
3 of 4 checks passed
@SJuliez SJuliez deleted the boardview-extract-shadowmap branch May 1, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For New Dev Cycle This PR should be merged at the beginning of a dev cycle
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant