Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close loopholes that allow off-board arty to attempt Flak attacks at … #5208

Merged
merged 3 commits into from
Feb 27, 2024

Conversation

Sleet01
Copy link
Collaborator

@Sleet01 Sleet01 commented Feb 26, 2024

…on-board Aeros.

Noticed this while testing another fix with a pair of large combined-arms forces run by Princess: off-board artillery units firing munitions that get the Flak bonus were targeting Aerospace units during the Indirect phase.

This is wrong for two reasons (see TacOps: AR):

  1. Flak attacks are direct fire, not indirect.
  2. An artillery unit has to be on the same map or board as the target Aerospace unit to use direct Flak attacks.

This closes two avenues for targeting Aerospace with Indirect attacks from off-board (but does not deter indirect attacks at, say, airborne VTOLs).

Testing:

  • Ran all 3 projects' unit tests.
  • Tested with manual and bot-controlled off-board artillery units targeting on-board ASFs, Dropships, and VTOLs.

@Sleet01
Copy link
Collaborator Author

Sleet01 commented Feb 27, 2024

Apologies, ran into a couple of other wrinkles when following up with the Aerospace player community.

@SJuliez SJuliez merged commit 78bf7ae into MegaMek:master Feb 27, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants