New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make emi description constants public for mekhq #5172

Merged

SJuliez merged 2 commits into MegaMek:master from kuronekochomusuke:emiPublicDescription

Feb 22, 2024

Collaborator

kuronekochomusuke commented Feb 15, 2024 •

edited

Loading

make emi description constants public for mekhq

need for MegaMek/mekhq#3834


          make public for mekhq

003528d

Collaborator

Sleet01 commented Feb 15, 2024

I don't see any issues, but I wonder if there's a better place for public strings. That, or keep the strings private and make a public getter?


          use function to return value

05f1c7d

SJuliez approved these changes

View reviewed changes

SJuliez added the For New Dev Cycle label

kuronekochomusuke removed the For New Dev Cycle label

SJuliez merged commit c3ed045 into MegaMek:master

4 checks passed

kuronekochomusuke deleted the emiPublicDescription branch

April 20, 2024 14:12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet