Fix 4670: Hide entity statblocks from the hex tooltip when entity is hidden #5171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Sleet01
commented
Feb 16, 2024
| StringBuffer sbEntity = new StringBuffer(); | ||
| appendEntityTooltip(sbEntity, entity); | ||
| result += sbEntity.toString(); | ||
| if (EntityVisibilityUtils.detectedOrHasVisual(localPlayer, game, entity)) { |
There was a problem hiding this comment.
Sorry for the format spam; this is the actual change in this file.
SJuliez
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes adding the entity statblocks conditional on whether they are visible to the current local player; previously they were added unconditionally, even if the entity were hidden. Double Blind did hide this information, but through a different mechanism.
Testing:
Close #4670