Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switch to using name : code maps for advanced search combo box loads #5136

Merged
merged 4 commits into from
Feb 8, 2024
Merged

switch to using name : code maps for advanced search combo box loads #5136

merged 4 commits into from
Feb 8, 2024

Conversation

kuronekochomusuke
Copy link
Collaborator

@kuronekochomusuke kuronekochomusuke commented Feb 6, 2024 •
edited
Loading

  • fix issue with armor type search expecting the list of types to be in the order of the armor type codes
  • allArmorNames() was returning these out of order
  • switch others to a name : code map for the combo box loads to reduce the chance of errors with these
  • Tech Base does not have codes, so left it as is

@kuronekochomusuke kuronekochomusuke marked this pull request as draft February 6, 2024 23:55
@kuronekochomusuke kuronekochomusuke added Bug Advanced Search RFE's related to improving the advanced search. labels Feb 6, 2024
@kuronekochomusuke kuronekochomusuke marked this pull request as ready for review February 7, 2024 00:39
@neoancient neoancient merged commit 620d24c into MegaMek:master Feb 8, 2024
4 checks passed
@kuronekochomusuke kuronekochomusuke deleted the advancedSearchCodeName branch February 18, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neoancient neoancient neoancient approved these changes

Assignees
No one assigned
Labels
Advanced Search RFE's related to improving the advanced search. Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kuronekochomusuke @neoancient