QuirkEntry: remove maximum slot number check #5012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickAragua
reviewed
Jan 4, 2024
NickAragua
approved these changes
Jan 8, 2024
HammerGS
added a commit
that referenced
this pull request
Jan 9, 2024
+ PR #5024: Mech summary invalid + PR #5023: Correct conversion exception causing search to not work + Fix #5015: Add advanced search for gyro + PR #5014: Fix CF warning sprite to work with isometric view + PR #5012: QuirkEntry: remove maximum slot number check (fixes MegaMekLab#1364) + PR #4992: Don't display engine rating for SV engines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Weapon quirks are allowed on large craft and the slot numbers there can be higher than 11. The slot number test in the QuirkEntry constructor was obstructing this.
Fixes MegaMek/megameklab#1364