Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weight calculation #4973

Merged
merged 2 commits into from
Dec 26, 2023
Merged

Weight calculation #4973

merged 2 commits into from
Dec 26, 2023

Conversation

SJuliez
Copy link
Member

@SJuliez SJuliez commented Dec 20, 2023

MML shows a weight value that is rounded to half tons, as per TM p22. During construction the shown value should be accurate, as e.g. Clan MGs only weigh only 0.25t. This PR adds methods so that an exact value can be obtained. The standard method still returns the rounded value, now also for units other than Meks and tanks.

An MML PR changes the weight display accordingly.

Converted to draft as there's an error in SV weight calculation

@SJuliez SJuliez marked this pull request as ready for review December 21, 2023 17:08
@neoancient neoancient merged commit b02b154 into MegaMek:master Dec 26, 2023
4 checks passed
@SJuliez SJuliez deleted the weight-calc branch February 4, 2024 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants