#4876 Fix Unit Display General tab rendered blank when switching units.

[HoneySkull]

This is a proposed fix for #4876. This code change moves the unit display select entity logic before BoardView setup and rendering methods. I cannot 100% explain why this order of operations works, but it seems to be race condition in the Java Swing component repainting that occurs as methods like BoardView.setHighlightColor() trigger a repaint().

It doesn't appear there are any side-effects to moving this call up in the order of operations as it appears all the other tabs update as expected as new units are selected in the movement phase.

Fixes #4876
Fixed #4444

[kuronekochomusuke]

this fixes the unit summary for me, but I am still getting blank move and skip movement buttons when zoomed out to the max

[HoneySkull]

this fixes the unit summary for me, but I am still getting blank move and skip movement buttons when zoomed out to the max

I've been able to reproduce the blank move menu only by setting the skin to "plainSkin.xml" in the client settings as described in the earlier issue #4444. This fix doesn't fix both the issues, but I have a hunch they both have a similar root cause.

[kuronekochomusuke]

it now fixes both issues for me