Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds 1 new Searchlight option to MegaMek Client options. #4931

Conversation

Sleet01
Copy link
Collaborator

@Sleet01 Sleet01 commented Nov 29, 2023

  1. Start with Searchlights on [Default: true] = Searchlights are set on at Deployment; this gives the benefit of higher visibility from the first activation.
    2. Searchlights toggle on/off [Default: true] = Searchlights, once turned on in the Movement phase, remain on until toggled off in the next movement phase. (This turned out to not be necessary)

Setting both options the first option to "On" (default) makes Searchlights automatically start on and stay on for night missions, which some users have requested.

NB: Because of the way Searchlights are implemented, toggling a Searchlight off does not effect that movement phase, but will persist from the next phase.

Tested against Princess in various night conditions; confirmed that Searchlights still work correctly and Princess still uses them correctly.

Close #4930

@Sleet01 Sleet01 changed the title Adds 2 new Searchlight options to MegaMek Client options. Adds 1 new Searchlight option to MegaMek Client options. Nov 29, 2023
@kuronekochomusuke
Copy link
Collaborator

kuronekochomusuke commented Nov 29, 2023

think you still need to entity.setIlluminated(false) each round while not isDeployment()

just always set to to false there and the setIlluminated will leave it on if you have the search light on

public void setIlluminated(boolean arg) {
    illuminated = searchlightIsActive || arg;
}

@NickAragua NickAragua merged commit 94266d8 into MegaMek:master Dec 5, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFE: Add Client options to make Searchlights [ ] start on.
3 participants