Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dont set gm to an observer when they have no units #4928

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

kuronekochomusuke
Copy link
Collaborator

  • don't set gm to an observer when they have no units left.
  • this fixes an issue when using the gm done option and the gm has no units. causing the report phases to automatically skip, since there is no one set to check for done.

@kuronekochomusuke kuronekochomusuke added Bug GM Tools All things related to the GM Tools project. labels Nov 28, 2023
@NickAragua NickAragua merged commit dd42118 into MegaMek:master Dec 5, 2023
4 checks passed
@kuronekochomusuke kuronekochomusuke deleted the gmDoneObserver branch December 31, 2023 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug GM Tools All things related to the GM Tools project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants