Fix for 3095 - no +1 TMM for jumping WiGE #4912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes issue MegaMek#3095, but only for non-airborne WiGE that jump. Airborne jumping WiGE are already getting a +1 TMM from being airborne. Also fixes an issue where immobile / crashing WiGE are treated as other land vehicles and sink immediately; in fact by TW pg 55 they float and treat water as clear terrain and do not sink due to being immoble (q.v.) Close MegaMek#3095.
NickAragua
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #3095, but only for non-airborne WiGE that jump. Airborne jumping WiGE are already getting a +1 TMM from being airborne and these are not cumulative with each other (TW pg 307, ATTACK MODIFIERS TABLE).
Also fixes an issue where immobile / crashing WiGE are treated as other land vehicles and sink immediately; according to TW pg 55 they float and treat water as clear terrain, acting as naval vessels when landed on water, and so do not sink due to being immobile (q.v.).
Close #3095.