Move Unit Roles to Unit Files #4903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # megamek/data/mechfiles/mechs/3060u/Yu Huang Y-H10G.mtf # megamek/data/mechfiles/mechs/XTRs/Primitives IV/Xanthos XNT-2O.mtf # megamek/data/mechfiles/vehicles/XTRs/Primitives III/Korvin KRV-2.blk # megamek/src/megamek/utilities/MechCacheCSVTool.java
# Conflicts: # megamek/data/mechfiles/mechs/3055U/Anvil ANV-3M.mtf # megamek/data/mechfiles/mechs/3075/Jabberwocky ConstructionMech JAW-66D.mtf # megamek/data/mechfiles/mechs/3145/Davion/Antlion LK-3D.mtf # megamek/data/mechfiles/mechs/3145/Davion/Templar III TLR2-OD.mtf # megamek/data/mechfiles/mechs/3145/NTNU RS/Mangonel MNL-4S.mtf # megamek/data/mechfiles/mechs/3145/NTNU RS/Templar TLR1-OR.mtf # megamek/data/mechfiles/mechs/3145/Republic/Ares ARS-V1 Zeus.mtf # megamek/data/mechfiles/mechs/3145/Republic/Poseidon PSD-V2.mtf # megamek/data/mechfiles/mechs/XTRs/Liao/Vindicator VND-3LD (Dao).mtf # megamek/data/mechfiles/mechs/XTRs/Steiner/Banshee BNC-11X.mtf # megamek/src/megamek/common/loaders/BLKFile.java
neoancient
approved these changes
Nov 19, 2023
|
I spotted check a bunch of units that they seemed right. |
|
Going to merge this, as I'm working on some infantry stuff and don't want to create too many conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title says, this moves the unit roles into the mtf/blk files and removes the way they are currently handled as a single file. On the MML side there is an accompanying editor update.
I notice this is difficult to review because of all the unit files. If necessary I can try uploading a draft that only has the code changes.