Fix for space station rotation #4895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per SO, p. 63, (civilian) space stations can accumulate 0.2 thrust per turn and rotate one hexside when they have acquired a full point of thrust. Military space stations can rotate every turn. MM checks the isBattlestation field to make this determination. Though the loader checks for the field and sets it, it is not written to the blk file and none of the unit files have it. The military checkbox in MML sets the designType field, which was added later as part of implementation of sensor rules. Since the older isBattlestation field provides no additional information, I have removed it to standardize on the designType field.
Fixes #3861