-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Beast mounted infantry #4883
Merged
Merged
Beast mounted infantry #4883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickAragua
reviewed
Nov 14, 2023
I'm starting to get sprites in for the units I made. Once I get them I'll look at committing to the branch before merging if that works. |
NickAragua
reviewed
Nov 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple minor questions/possible cleanup issues.
No default sprites set as not sure of the naming conventions yet.
NickAragua
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements beast-mounted infantry rules from TO: AU&E, pp. 107-8, with construction rules on 106.The table of creatures is presented as sample types, so I've implemented it to allow custom stats, but the creatures in the table are included as standard presets. Some adjustments were needed to submarine movement to allow creature to move onto land when the ability is indicated. I also made a change to deployment that has such units deploy at a depth equal to the height, so that when at the surface they extend one level above the surface. This has not been an issue before because all submarine units are only one level high, but very large and monstrous mounts are taller, as are the yet-unimplemented large naval support vehicles. There is also now a tracker for how long an entity has been entirely submerged, used to track air reserves. I've added a line to the unit tooltip that shows the number of rounds of air remaining when relevant.