Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MekView updates #4822

Merged
merged 3 commits into from
Oct 18, 2023
Merged

MekView updates #4822

merged 3 commits into from
Oct 18, 2023

Conversation

SJuliez
Copy link
Member

@SJuliez SJuliez commented Oct 11, 2023

Some updates to the unit summary:

  • adds a toolbar like on the AS Card that allows font configuration and copying the info as text or html
  • removes some background coloring that wasnt compatible with dark look and feel, now damage is colored in the configurable warning color aka red and caution color aka yellow
  • scrolling should be smoother (smaller increment)
  • the tables (armor, weapons etc) now have a little space between columns, most columns are centered
  • unnecessary empty lines between text blocks have been removed
  • html tags in the fluff text are removed for text export, so simple html tags like <P>, <BR>, <B> and <I> can be used to add line breaks and formatting
  • the MUL link from the "Source:" text has been removed, there's now a button
  • instead, when the source is Shrapnel, a link to the Shrapnel website on bg.battletech.com is present
  • in the lobby, the summary scales correctly according to GUI scaling (override on SetVisible)

image

Copy link
Collaborator

@rjhancock rjhancock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sanity check looked fine to me.

Copy link
Member

@NickAragua NickAragua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question, one minor change request.

megamek/src/megamek/common/MechView.java Outdated Show resolved Hide resolved
megamek/src/megamek/common/MechView.java Show resolved Hide resolved
@SJuliez SJuliez merged commit fc1fc74 into MegaMek:master Oct 18, 2023
4 checks passed
@SJuliez SJuliez deleted the MekView branch December 12, 2023 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants