Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow any player to become GM in lobby without a vote #4644

Merged
merged 2 commits into from
Jul 21, 2023
Merged

Allow any player to become GM in lobby without a vote #4644

merged 2 commits into from
Jul 21, 2023

Conversation

pakfront
Copy link
Collaborator

fixes #4641

@pakfront pakfront marked this pull request as ready for review July 18, 2023 23:51
SJuliez
SJuliez requested changes Jul 19, 2023
View reviewed changes
Copy link
Member

@SJuliez SJuliez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One request, otherwise good to go

megamek/src/megamek/server/commands/GameMasterCommand.java Outdated Show resolved Hide resolved
@pakfront pakfront requested a review from SJuliez July 21, 2023 03:20
@SJuliez SJuliez merged commit 7b425de into MegaMek:master Jul 21, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SJuliez SJuliez SJuliez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Do not require /allowGM vote for GM role in Lobby
2 participants
@pakfront @SJuliez