Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit Selector #4549

Merged
merged 1 commit into from
Jun 23, 2023
Merged

Unit Selector #4549

merged 1 commit into from
Jun 23, 2023

Conversation

SJuliez
Copy link
Member

@SJuliez SJuliez commented Jun 22, 2023

Changes to the unit selector:

  • use a normal font again instead of the awful monospaced
  • add some formatting to price and tonnage, controlled by the selected language (at least in MM, probably always US for now in MML/MHQ)
  • centers some of the columns
  • allows multiple space-separated search tokens in the text search (it is now possible to search for "Achi Sqd5" to find all Sqd5 Achileus BAs)

image

NickAragua
NickAragua approved these changes Jun 23, 2023
View reviewed changes
Copy link
Member

@NickAragua NickAragua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, just one question.

megamek/src/megamek/client/ui/swing/dialog/AbstractUnitSelectorDialog.java
@@ -854,16 +862,10 @@ public Class<?> getColumnClass(int col) {
return getValueAt(0, col).getClass();
}

@Override
public boolean isCellEditable(int row, int col) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this is false in the base class?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. (IDEA told me this is equal to the base class)

@SJuliez SJuliez merged commit e0a8b4d into MegaMek:master Jun 23, 2023
@SJuliez SJuliez deleted the UnitSelector branch June 28, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickAragua NickAragua NickAragua approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SJuliez @NickAragua