Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 206: Weapon Specialist #4510
Issue 206: Weapon Specialist #4510
Changes from 1 commit
fec6bef
1126fa6
0f1638c
05c131a
70a1fb8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment here, which is that the "rapid fire autocannons" weapon allows standard ACs to behave like UACs (at the risk of exploding), so I think standard autocannons should be included in this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a suggestion, I have added a GameOptions parameter here based on which all ACs may be allowed. Both MM and MHQ can supply GameOptions and so it'll reflect the state of the game/campaign. The GameOptions can be nulled if necessary but I have not added versions without the additional parameter as we'd really want the GameOpts to be given. I think MML won't need these methods.
Aside from that I've removed Streaks from Sandblaster as they don't use the cluster table and C3 from the weapon specialist (hehe).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@NickAragua Any thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, lost track of this one.
I think there are some situations (mostly involving high powered ECM as I recall) where Streak launchers revert to cluster rolls, so there may be a case for Sandblaster applying to them.
Tying sandblaster availability to "rapid fire AC" rules is ok.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I've re-allowed Streaks for those Angel ECM encounters and removed infantry attacks (leg attack etc) from Weapon Specialist (doesn't seem in the spirit of the rules)