Princess configuration #3041
Merged
Princess configuration #3041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: megamek/i18n/megamek/client/messages_en.properties megamek/mmconf/princessBehaviors.xml megamek/src/megamek/client/ui/swing/lobby/ChatLounge.java megamek/src/megamek/common/Board.java megamek/src/megamek/common/IBoard.java
NickAragua
requested changes
Aug 3, 2021
| coordsList.setCellRenderer(new BuildingHexRenderer()); | ||
| coordsList.setFont(UIUtil.getScaledFont()); | ||
| coordsList.setVisibleRowCount(6); | ||
| coordsList.setPrototypeCellValue(new Coords(-21, 22)); |
There was a problem hiding this comment.
This seems a little specific.
There was a problem hiding this comment.
If you mean the prototype cell value, that's only passed to the renderer to get the cell size when the list is empty. This prevents it from changing size when it goes from empty to containing items (the changed size doesn't appear directly, only when resizing the dialog, but then it looks a little silly)
| private static JMenu prioTargetMenu(ClientGUI cg, boolean enabled, ActionListener listener, | ||
| Collection<Entity> entities) { | ||
|
|
||
| JMenu menu = new JMenu("Set Prio Target for"); |
There was a problem hiding this comment.
I'm sure that we have enough bits that we can spell "Priority" fully.
|
Just a comment from the forums that might be applicable here. https://bg.battletech.com/forums/megamek-games/princess-settings-popup-tooltip-vs-help/ |
NickAragua
approved these changes
Aug 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2986
Resolves #2958
Resolves #2853