multiple fixes related to counter-battery fire #3011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickAragua
requested review from
sixlettervariables,
neoancient and
Windchild292
|
This supposed to point to MekHQ 2733? |
|
Yes |
| * Utility function used to safely tell whether two Targetables are in the same hex. | ||
| * Does not throw exceptions in case of nulls. | ||
| */ | ||
| public static boolean atSamePosition(Targetable first, Targetable second) { |
There was a problem hiding this comment.
Nullable annotate both first and second
There was a problem hiding this comment.
Further, for the name... isAtSamePosition would probably be a better name than atSamePosition.
megamek/src/megamek/common/weapons/ArtilleryWeaponIndirectFireHandler.java
Outdated
Show resolved
Hide resolved
…Handler.java Co-authored-by: Justin Bowen <39067288+Windchild292@users.noreply.github.com>
Windchild292
approved these changes
Jul 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These prevent several game-blocking and non-game-blocking NPEs which occur when handling counter-battery fire against a unit that was previously destroyed.
Fixes mekhq #2733